KDS-547: Tokenization of Python scripting – Temporary Values Panel#39
Merged
HedgehogCode merged 1 commit intomasterfrom Jan 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements tokenization updates for the Python scripting Temporary Values Panel, migrating from legacy KNIME component styles to the KNIME Design System (KDS). The changes focus on updating CSS styling to use KDS design tokens and replacing the old Button component with KdsButton.
- Migrated CSS from hardcoded values to KDS design tokens for consistent theming
- Replaced
@knime/componentsButton with@knime/kds-componentsKdsButton - Updated table header/body styling to follow KDS spacing and visual patterns
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| PythonWorkspaceHeader.vue | Updated table header styling with KDS tokens, changed sticky positioning structure, added KDS font and color tokens |
| PythonWorkspaceBody.vue | Applied KDS spacing, typography, and hover state styling to table rows |
| PythonWorkspace.vue | Migrated Button to KdsButton, replaced hardcoded spacing/colors with KDS tokens throughout |
| package.json | Added @knime/kds-components dependency and downgraded @vueuse/core |
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspaceHeader.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspaceBody.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Outdated
Show resolved
Hide resolved
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
from
cf613ca to
a7bea4a
Compare
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
from
a7bea4a to
ef340ba
Compare
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
2 times, most recently
from
c2d35a6 to
8a70956
Compare
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
from
8a70956 to
8e86d30
Compare
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
from
8e86d30 to
08ccdb4
Compare
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Outdated
Show resolved
Hide resolved
HedgehogCode
requested changes
Jan 20, 2026
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspaceBody.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspaceBody.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspaceHeader.vue
Outdated
Show resolved
Hide resolved
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspaceHeader.vue
Outdated
Show resolved
Hide resolved
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
from
08ccdb4 to
d347887
Compare
HedgehogCode
force-pushed
the
KDS-547-python-scripting-temp-values
branch
2 times, most recently
from
d347887 to
3621f4b
Compare
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Outdated
Show resolved
Hide resolved
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
from
3621f4b to
80561f3
Compare
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Show resolved
Hide resolved
|
senemdilli
force-pushed
the
KDS-547-python-scripting-temp-values
branch
2 times, most recently
from
d798031 to
2d28d06
Compare
HedgehogCode
approved these changes
Jan 27, 2026
Contributor
|
This PR is good to be merged and can be merged right after the 5.10 release process happened. |
HedgehogCode
force-pushed
the
KDS-547-python-scripting-temp-values
branch
from
2d28d06 to
3b46d7e
Compare
org.knime.python3.scripting.nodes/js-src/src/components/PythonWorkspace.vue
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.